Skip to content

fix: v2 apis#627

Merged
davidecarpini merged 6 commits into
mainfrom
multisig-veworld-v2-apis
Jun 5, 2026
Merged

fix: v2 apis#627
davidecarpini merged 6 commits into
mainfrom
multisig-veworld-v2-apis

Conversation

@davidecarpini
Copy link
Copy Markdown
Member

@davidecarpini davidecarpini commented May 20, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026 •
edited
Loading

Review Change Stack

Warning

Review limit reached

@davidecarpini, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 15 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9f5ad356-f797-442d-8ee5-d426670a9989

📥 Commits

Reviewing files that changed from the base of the PR and between 852b45a and e92b1cc.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (14)
  • packages/vechain-kit/package.json
  • packages/vechain-kit/src/components/AccountModal/Components/AccountSelector.tsx
  • packages/vechain-kit/src/components/AccountModal/Contents/Profile/Components/ProfileCard/ProfileCard.tsx
  • packages/vechain-kit/src/components/AccountModal/Contents/Profile/ProfileContent.tsx
  • packages/vechain-kit/src/components/AccountModal/Contents/SelectWallet/SelectWalletContent.tsx
  • packages/vechain-kit/src/components/common/AccountAvatar.tsx
  • packages/vechain-kit/src/components/common/AddressDisplay.tsx
  • packages/vechain-kit/src/hooks/api/vetDomains/useGetAvatarOfAddress.ts
  • packages/vechain-kit/src/hooks/api/vetDomains/useVechainDomain.ts
  • packages/vechain-kit/src/hooks/api/wallet/useSwitchWallet.ts
  • packages/vechain-kit/src/hooks/api/wallet/useWallet.ts
  • packages/vechain-kit/src/hooks/api/wallet/useWalletStorage.ts
  • packages/vechain-kit/src/hooks/login/useConnectWithDappKitSource.ts
  • packages/vechain-kit/src/languages/en.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch multisig-veworld-v2-apis

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Agilulfo1820
Copy link
Copy Markdown
Member

Agilulfo1820 commented May 20, 2026 •
edited
Loading

Ad back logout btn in the address field (near the copy btn) as it was before, since the new pattern is a bit weird (with 2 full btns and an icon btn).
Or let's find an alternative ui

@davidecarpini
Copy link
Copy Markdown
Member Author

davidecarpini commented May 21, 2026

removed the button on veworld as discussed and tested on wallet-connect and social-login and looks good @Agilulfo1820
Screenshot 2026-05-21 at 11 56 28
Screenshot 2026-05-21 at 11 56 10
Screenshot 2026-05-21 at 11 55 31

@Agilulfo1820
Copy link
Copy Markdown
Member

Agilulfo1820 commented May 28, 2026

@davidecarpini some issue with the build to fix:

Error: @vechain/vechain-kit#build: command (/home/runner/work/vechain-kit/vechain-kit/packages/vechain-kit) /tmp/xfs-7cbb0a65/yarn run build exited (2) cache miss, executing a3546dc0e32739f7 src/components/AccountModal/Contents/SelectWallet/SelectWalletContent.tsx(63,9): error TS2339: Property 'requestPermissions' does not exist on type '{ setSource: (source: WalletSource) => void; availableWallets: WalletSource[]; disconnect: () => void; connect: ConnectCallback; account: string | null; ... 12 more ...; isSwitchWalletEnabled: boolean; }'. src/components/AccountModal/Contents/SelectWallet/SelectWalletContent.tsx(64,9): error TS2339: Property 'revokeAccount' does not exist on type '{ setSource: (source: WalletSource) => void; availableWallets: WalletSource[]; disconnect: () => void; connect: ConnectCallback; account: string | null; ... 12 more ...; isSwitchWalletEnabled: boolean; }'. src/components/AccountModal/Contents/SelectWallet/SelectWalletContent.tsx(384,29): error TS7006: Parameter 'e' implicitly has an 'any' type. src/hooks/api/wallet/useWallet.ts(98,9): error TS2339: Property 'accounts' does not exist on type '{ setSource: (source: WalletSource) => void; availableWallets: WalletSource[]; disconnect: () => void; connect: ConnectCallback; account: string | null; ... 12 more ...; isSwitchWalletEnabled: boolean; }'. src/hooks/api/wallet/useWallet.ts(99,9): error TS2339: Property 'setActiveAccount' does not exist on type '{ setSource: (source: WalletSource) => void; availableWallets: WalletSource[]; disconnect: () => void; connect: ConnectCallback; account: string | null; ... 12 more ...; isSwitchWalletEnabled: boolean; }'.

@Agilulfo1820
Copy link
Copy Markdown
Member

Agilulfo1820 commented May 28, 2026

@davidecarpini solved a conflict, kept both my and your changes.
My changes were to fix a bug with wallet connect modal not closing

@Agilulfo1820 Agilulfo1820 added safe-to-deploy Label to approve external PRs to preview environment safe-to-build labels May 28, 2026
@davidecarpini
fix(deps): bump @vechain/dapp-kit-react to 2.2.0
39ec05e 
The v2 multisig flow uses the new dapp-kit wallet APIs (accounts,
setActiveAccount, requestPermissions, revokeAccount) which only exist
in @vechain/dapp-kit-react >= 2.2.0. The dependency was still pinned to
2.1.0-rc.5, so the published package lacked those types and the build
failed in CI (it only compiled locally via a yalc-linked dapp-kit).
Bump both dependencies and peerDependencies to 2.2.0.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026 •
edited
Loading

Size Change: +49.5 kB (+0.56%)

Total Size: 8.89 MB

Filename Size Change
packages/vechain-kit/dist/index-BImGnftH.d.mts 0 B -185 kB (removed) 🏆
packages/vechain-kit/dist/index-BImGnftH.d.mts.map 0 B -49.2 kB (removed) 🏆
packages/vechain-kit/dist/index-CKU_EtcN.d.mts 0 B -5.63 kB (removed) 🏆
packages/vechain-kit/dist/index-CKU_EtcN.d.mts.map 0 B -2.99 kB (removed) 🏆
packages/vechain-kit/dist/index-CN2s1ue2.d.cts 0 B -185 kB (removed) 🏆
packages/vechain-kit/dist/index-CN2s1ue2.d.cts.map 0 B -50.3 kB (removed) 🏆
packages/vechain-kit/dist/index.cjs 1.14 MB +3.41 kB (+0.3%)
packages/vechain-kit/dist/index.cjs.map 2.85 MB +20.7 kB (+0.73%)
packages/vechain-kit/dist/index.mjs 1.1 MB +3.33 kB (+0.3%)
packages/vechain-kit/dist/index.mjs.map 2.79 MB +20.7 kB (+0.75%)
packages/vechain-kit/dist/index--hSO7Xv4.d.mts 5.63 kB +5.63 kB (new file) 🆕
packages/vechain-kit/dist/index--hSO7Xv4.d.mts.map 2.99 kB +2.99 kB (new file) 🆕
packages/vechain-kit/dist/index-BcQwrTbs.d.cts 186 kB +186 kB (new file) 🆕
packages/vechain-kit/dist/index-BcQwrTbs.d.cts.map 50.5 kB +50.5 kB (new file) 🆕
packages/vechain-kit/dist/index-CDTVblFQ.d.mts 186 kB +186 kB (new file) 🆕
packages/vechain-kit/dist/index-CDTVblFQ.d.mts.map 49.3 kB +49.3 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
packages/vechain-kit/dist/assets 4.1 kB
packages/vechain-kit/dist/assets-C0RHiZ9a.mjs 51.4 kB
packages/vechain-kit/dist/assets-C0RHiZ9a.mjs.map 74.6 kB
packages/vechain-kit/dist/assets-CZs6EVH8.cjs 58.9 kB
packages/vechain-kit/dist/assets-CZs6EVH8.cjs.map 76.1 kB
packages/vechain-kit/dist/assets/index.cjs 716 B
packages/vechain-kit/dist/assets/index.d.cts 973 B
packages/vechain-kit/dist/assets/index.d.mts 973 B
packages/vechain-kit/dist/assets/index.mjs 718 B
packages/vechain-kit/dist/index-nRf3KRll.d.cts 5.63 kB
packages/vechain-kit/dist/index-nRf3KRll.d.cts.map 2.99 kB
packages/vechain-kit/dist/index.d.cts 24.5 kB
packages/vechain-kit/dist/index.d.mts 24.5 kB
packages/vechain-kit/dist/utils 4.1 kB
packages/vechain-kit/dist/utils-C4gc1L9t.cjs 27.4 kB
packages/vechain-kit/dist/utils-C4gc1L9t.cjs.map 68.2 kB
packages/vechain-kit/dist/utils-DPIscp9_.mjs 22.2 kB
packages/vechain-kit/dist/utils-DPIscp9_.mjs.map 67.5 kB
packages/vechain-kit/dist/utils/index.cjs 2.02 kB
packages/vechain-kit/dist/utils/index.d.cts 3.1 kB
packages/vechain-kit/dist/utils/index.d.mts 3.1 kB
packages/vechain-kit/dist/utils/index.mjs 2.04 kB

compressed-size-action

@davidecarpini davidecarpini marked this pull request as ready for review June 5, 2026 07:32
@davidecarpini davidecarpini merged commit b9e3b1d into main Jun 5, 2026
9 checks passed
@davidecarpini davidecarpini deleted the multisig-veworld-v2-apis branch June 5, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Agilulfo1820 Agilulfo1820 Agilulfo1820 approved these changes

Assignees

No one assigned

Labels

safe-to-build safe-to-deploy Label to approve external PRs to preview environment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidecarpini @Agilulfo1820